Fix various parameter configuration issues #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating controller params, the controller dt could be updated without updating the feedback controller's dt.
This commit switches from virtual C-stye variadic method implementations for debug(), info(), warning(), and error() to variadic template implementations with internal virtual methods that could be overwritten by subclasses. This allows easier wrapping around the RCLCPP logging framework set up in ROS 2. Switching to variadic templates also allows for a potential future change to allow device-side logging with more limited functionality (no colored output wrapping or file stream selection for printing). As I'm still unsure how to address the device-side storage of the logger across multiple different classes safely, this will be left for future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits address a couple of issues related to parameter configuration in the library. The first commit adds the ability in the plant to update the sampling distribution parameters in a multi-threaded scenario. The second fixes a small bug where updating the dt through
setParams()of the Controller class would not update the dt of its feedback controller.